Consolidate agreement functions into LcPtr<EVP_PKEY> #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 95.80% 92.35% -3.45%
==========================================
Files 61 71 +10
Lines 8143 9277 +1134
Branches 0 9277 +9277
==========================================
+ Hits 7801 8568 +767
- Misses 342 429 +87
- Partials 0 280 +280 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
evp-pkey-derive
branch
from
734f962 to
4316e03
Compare
justsmth
force-pushed
the
evp-pkey-derive
branch
from
4316e03 to
5aaa88f
Compare
smittals2
approved these changes
Aug 13, 2025
skmcgrail
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We previously had two nearly identical methods for performing agreement. This change consolidates them into an
agreefunction inLcPtr<EVP_PKEY>Testing:
No changes to tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.